Revert UMD for now, due to #13812. #13904
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Will hopefully revert this reversion and land a fully-working version of UMD in v3.3.0. Revert "some changes from #13801 - add strict mode back and ==" This reverts commit 2b302f6. Revert "Fix regression of #10038 introduced by #13772" This reverts commit e9d6756. Revert "MD/CommonJS/Globals #12909" This reverts commit 1c6fa90. Revert "address #13811" This reverts commit f347d7d. Conflicts: js/carousel.js js/collapse.js js/dropdown.js js/modal.js js/tab.js js/tooltip.js
|
👍 |
|
LGTM too. |
|
cool, thanks for doing this @cvrebert |
fat
added a commit
that referenced
this pull request
Jun 24, 2014
Revert UMD for now, due to #13812.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Revert UMD (#13772 & friends) for now, due to #13812.
We'll hopefully be able to revert this reversion and land a fully-working version of UMD in v3.3.0, after we figure out a solution for #13812. But right now, we just want to get v3.2.0 shipped already, since it's late, and UMD is our sole blocker at this point.
To: @fat @XhmikosR for review.
For less confusion, I recommend reading the whitespace-ignorant diff:
https://github.com/twbs/bootstrap/pull/13904/files?w=1